Handbook
Gradient Handbook / Product Team / DevOps / Codebase Maintenance / Regular Branch Review Edit this page

Regular Branch Review

On github page of our monorepo, go to branches -> All branches.

In the perfect world you should only see gray or green PR icons and all PRs should not stay inactive for more than 2 months. Gray indicates a draft PR that is in progress. Green means a PR that is ready to be reviewed. The whole process of branch review is essentially about achieving this perfect picture.

We have a recurring Jira issue which pops up every two weeks and assigns one person to do the branch review. Here’s the course of actions:

  1. If a branch does not have a PR, ask the person who initialized it to create a draft PR. If it’s obvious where the PR should point to, you can do it by yourself.

  2. If a branch has a draft PR and the latest activity has been more than two months ago, check with the PR owner whether it should be closed or reviewed and merged. Sometimes you can identify that a PR should be merged earlier, e.g. when it’s a project PR and corresponding project’s slack channel has been archived.

  3. If a branch has a PR that is marked as “ready for review”, check with the PR owner whether they are waiting for a specific person to do the review, or if it’s fine if you do a quick review and merge.

  4. If a branch has a PR and it’s already merged, the branch should be removed.